Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Fix requirejs for other locations than apps/ #1627

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Conversation

juliushaertl
Copy link
Contributor

Fix for https://github.com/owncloud/mail/issues/1163

This will use a dynamic baseUrl for require.js to make the mail app work within other app folders than apps/.

@mention-bot
Copy link

@juliushaertl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst and @Gomez to be potential reviewers

@ChristophWurst ChristophWurst added this to the 0.5.3 milestone Aug 25, 2016
@ChristophWurst
Copy link
Contributor

@juliushaertl @Gomez what are the steps to test this?

@juliushaertl
Copy link
Contributor Author

@ChristophWurst You need to add a secound path to the apps_path config.php (https://github.com/nextcloud/server/blob/master/config/config.sample.php#L689-L703)

Install the mail app into the additional apps path, enable it and try to access it.

Without the patch, require.js tries to load all javascript files from "apps/mail/js/..:" but they are stored in e.g. "apps-extra/mail/js/..."

@ChristophWurst
Copy link
Contributor

👍 works very nicely, thanks a lot 🚀

@ChristophWurst ChristophWurst merged commit 1f89ca8 into master Aug 25, 2016
@ChristophWurst ChristophWurst deleted the fix-app-folder branch August 25, 2016 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants