This repository has been archived by the owner on Nov 8, 2018. It is now read-only.
disable send/reply buttons unless recipient and either subject or message body is filled #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage body is filled, fix #99
|
The button looks the same both in enables and in disabled state. If the button changes color according to its state, it would be easier to recognize by the user :-) |
|
True, I also thought about that. Will fix it. :) |
|
@wurstchristoph fixed it in core with owncloud/core#15638 – please review. :) Does this pull request work fine otherwise? |
|
Nice! |
jancborchardt
added a commit
that referenced
this pull request
Apr 15, 2015
disable send/reply buttons unless recipient and either subject or message body is filled
|
sorry for the late reply. yup, works as expected - the button is disabled until some text is entered 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #99
Please review @RandolfCarter @seal20 – btw you’re also welcome in our IRC channel #owncloud-mail on freenode. :)
cc @DeepDiver1975 @wurstchristoph @zinks-