Doesn’t work on mobile

[jancborchardt]

On mobile, insertion of the app-navigation-toggle doesn’t seem to work. It does do that via js.js (see https://github.com/owncloud/core/blob/e2327f83ed60ca29fd1513a40bcefd26e52c54bf/core/js/js.js#L1158) but apparently this gets removed again later.

@Raydiation can you check that out? It works with all other apps using app-navigation and app-content, including the News app.

[BernhardPosselt]

Well you cant simply add it to #app-content since this area might and actually is generated automatically which is perfectly fine. Content inside the app must not be modified since you'll always generate undefined behaviour with it. Move HTML to a different place (maybe outside of #content) or give the app dev the power to add this feature on his own. The current implementation in core is too broken and IMO its not a notes app problem, therefore closing.

[BernhardPosselt]

Btw, it shoud also fail in the music app and the stable7 branch of the news app

[jancborchardt]

Music doesn’t have a sidebar, and it works perfectly for News.

The current implementation in core is too broken

I agree with you because that’s not how it should be done. Thing is it works for all apps – and if you have a better idea (which makes it work for all apps, including the Notes) then please suggest it. Currently Notes is the only app where this is a problem.

[jancborchardt]

See owncloud/core#9838, let’s continue there.