Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Word WOPI double present in env var in app-provider #3709

Closed
mmattel opened this issue May 6, 2022 · 2 comments
Closed

Word WOPI double present in env var in app-provider #3709

mmattel opened this issue May 6, 2022 · 2 comments
Labels
Status:Wontfix
Projects
Infinite Scale Team Board

Comments

@mmattel
Copy link
Contributor

mmattel commented May 6, 2022

In extension app-provider
Why do we need to have the word WOPI double present in the env name?

APP_PROVIDER_WOPI_WOPI_SERVER_IOP_SECRET
APP_PROVIDER_WOPI_WOPI_SERVER_EXTERNAL_URL

@butonic @micbar @wkloucek
@butonic
Copy link
Member

butonic commented May 6, 2022

The duplication of WOPI is caused by the sequence of driver names and their config option names. We could introduce two __ as a separator to indicate these boundaries.

@micbar micbar mentioned this issue May 10, 2022
Closed
45 tasks
@micbar micbar added this to Qualification in Infinite Scale Team Board via automation May 10, 2022
@micbar micbar moved this from Qualification to Refactor / Technical Debt in Infinite Scale Team Board May 10, 2022
@micbar
Copy link
Contributor

micbar commented Jul 4, 2022

Close as won't fix.

@micbar micbar closed this as completed Jul 4, 2022
Infinite Scale Team Board automation moved this from Refactor / Technical Debt to Done Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status:Wontfix
Projects
Infinite Scale Team Board
Status: Done
Infinite Scale Team Board
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@butonic @mmattel @micbar