Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty search list when sharee searches a folder that has been renamed by sharer #7262

Open
nabim777 opened this issue Sep 11, 2023 · 7 comments
Labels

Comments

@nabim777
Copy link
Member

nabim777 commented Sep 11, 2023

Describe the bug

When sharee searches the folder after renamed by sharer then the search list of sharee is empty.

Steps to reproduce

Steps to reproduce the behavior:

  1. As marie, create a folder folder1
  2. As marie, share a folder to einstein
  3. As einstein, accept the share
  4. As marie, rename folder folder1 to folder2
  5. for einstein, there is folder folder1 in share-with-me page

image
7. As einstein, search the folder folder1 using web UI

Expected behavior

The folder1 should be contains in search list
image

Actual behavior

The search list does not contains folder1
image

But
when einstein searches resources by name folder2
image

@phil-davis
Copy link
Contributor

phil-davis commented Sep 11, 2023

Yes, this is a problem. The back-end search facility needs to (somehow) understand that Einstein has a folder named folder1 in his view of his file-system.

And probably the back-end search-engine knows the latest name that Marie has given the folder, and it is indexed somewhere by that name. That is good for Marie, but not so good for Einstein.

And, if Einstein himself renames folder1 to folder3 locally for him, then the search-engine needs to find it by the name folder3 - so there are a few variations of renaming-actions that need to work and be tested.

@saw-jan
Copy link
Member

saw-jan commented Sep 12, 2023

CC @ScharfViktor

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Sep 12, 2023

I see that we have raised this issue here #6376 as well.
oc10 has same behavior:
Screenshot 2023-09-12 at 09 54 23

and based on this comment #6376 (comment), I understand that we want to leave it like it is, so we closed issue

@micbar
Copy link
Contributor

micbar commented Sep 12, 2023

Correct. Renaming shares does not affect both sides. Everybody can do renames which are not visible to the other share participants.

@saw-jan
Copy link
Member

saw-jan commented Sep 12, 2023

Understood, the renaming part is clear.
We need to be clear about the search. bug/feature?
By which name the sharee should search the received file? by the name that appears in the share-with-me page or by the name renamed by sharer of which the sharee don't have idea about? 🤔

@phil-davis
Copy link
Contributor

This issue NOT about the different names of the folder as seen by the sharer and sharee.

It is about what happens when the sharee tries to search for the folder after the sharer has changed the folder name (and the folder name for the sharee is the same as previously)

@micbar
Copy link
Contributor

micbar commented Sep 12, 2023

From my pov, the search needs to be consistent with the name in the file list / shared with me list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants