Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents are not loading at all on 10.0.1RC1 #175

Closed
tboerger opened this issue May 17, 2017 · 8 comments
Closed

Documents are not loading at all on 10.0.1RC1 #175

tboerger opened this issue May 17, 2017 · 8 comments

Comments

@tboerger
Copy link

I have tried to launch a demo, connected to a Collabora 2.0 instance. I have installed richdocuments through the marketplace (1.1.20). The example document is loading infinite. The only error I can see so far is a jQuery error within the browser console.

bildschirmfoto 2017-05-17 um 12 01 28

@pranavk
Copy link
Contributor

pranavk commented May 19, 2017

Hmm, OC.Upload which was available to richdocuments pre-10.0.1 RC1 seems to be undefined now.

@DeepDiver1975
Copy link
Member

Hmm, OC.Upload which was available to richdocuments pre-10.0.1 RC1 seems to be undefined now.

@PVince81 can you comment on this? THX

@PVince81
Copy link
Contributor

OC.Upload was renamed to OC.Uploader. In general it's not a public API.

There were some changes to that class which also required the gallery app to be changed.
In case it helps, see https://github.com/owncloud/gallery/pull/715/files#diff-57783a77dad9285b443294c9e7ed8d03R316

@gklimm
Copy link

gklimm commented May 21, 2017

@tboerger You have to change apps/richdocuments/js/documents.js line 1065 OC.Upload._isReceivedSharedFile to OC.Uploader._isReceivedSharedFile

This work for me ...

@pranavk
Copy link
Contributor

pranavk commented May 22, 2017

Any thoughts on removing this app view from the app. One can always create new documents and upload from the files view anyway; this app view just adds to complexity without any advantage.

@tboerger
Copy link
Author

@tboerger You have to change apps/richdocuments/js/documents.js line 1065 OC.Upload._isReceivedSharedFile to OC.Uploader._isReceivedSharedFile

This work for me ...

But to patch the files manually is not really a good solution :)

@gklimm
Copy link

gklimm commented May 22, 2017

I'm agree with you but the only way to make it run for now.
I have the same opinion like pranavk. When the filelist was extended with the option to make new documents, the gallery view make no sense anymore. Gallery view for office documents doesn't make sense for me anytime :)

@timar
Copy link
Contributor

timar commented May 22, 2017

Fixed in 1.1.21 that I've just published on marketplace. We have not removed the app view yet, we just check for existence of OC.Upload and OC.Uploader.

@timar timar closed this as completed May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants