New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that START < DUE if both set #351
Comments
We should prevent setting an earlier |
Yes, that would be nice. But to what?
For 1.: what is |
The calendar app uses option 2 exactly as you described it. It keeps the duration constant, if you change I would go with option 2 and keep the duration of the task fixed, but modify it a bit: only adjust the date in case the constraint is broken. So setting an invalid |
I like your proposed approach.It solves the problem elegantly and I think it does not confuse the users. |
I'm currently working on an implementation of this. However, I've found a special case, which I would like to discuss here. Let's take a task with What to do? I could set What do you think? @raimund-schluessler |
I would rather change the beginning, although I wonder if we should enforce this constraint also for all-day dates. Thunderbird does not even enforce this for date-time dates. Maybe @jancborchardt has an opinion too? |
Okay, I checked this again, and it seems that all implementations I'm using do allow |
So, we set |
Yes, I think that would be okay. Any doubts? |
You can test it already: https://github.com/nextcloud/tasks/tree/start-due-constraint |
No, I am fine with that. |
@raimund-schluessler @korelstar let’s also maybe continue discussion in the new repo – we can reopen the issue there or just do it on the pull request. Otherwise it’s confusing. :) |
@korelstar Please note that DAVdroid will now ignore I would strongly suggest to validate
There's a discussion about this topic at http://www.ietf.org/mail-archive/web/calsify/current/msg02217.html, which is linked from an erratum with status "held for document update": erratum 4626, which suggests adding this paragraph to the "New Restrictions" section:
I really don't have an opinion on what makes sense in this case and what doesn't (it does't matter for me, personally), but to minimize compatibility problems, I'd stick with the standard. |
@rfc2822 Thanks for your hints! This changes my opinion about this issue. Although I personally would like to see that @raimund-schluessler I will change the PR nextcloud/tasks#11 and enforce @jancborchardt I really dislike to disrupt the discussion by splitting it in two parts. But if everybody is fine with enforcing |
@rfc2822 Thanks for the hints.
@korelstar I agree with that. It would be nonsense to implement it in a way, that the compatibility is broken. Although I too would like |
@rfc2822 Do you have already any experiences from DAVdroid in practice since disallowing
Hence, the question is, if your changes in DAVdroid brake Apple compatibility. I don't have any Apple devices, so I can't examine this. |
RFC 5545 says about the
DUE
field:Currently, it is possible to create invalid tasks, because the tasks app doesn't validate this. Third-party applications using calendar data from ownCloud could produce errors due to such invalid tasks (e.g. DAVdroid, a calDAV synchronization app for android, does). This should be prevented by at least showing a warning if the user sets
DUE < START
. Better: enforce a valid task by correcting the dates.The text was updated successfully, but these errors were encountered: