Use FileList.files instead of DOM to get all images #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of infinite scrolling, not all file entries are in the DOM. This fix uses the FileList.files array instead.
|
@icewind1991 please review. |
|
@PVince81 made a fix to the calculation of the start index for when a folder contains more then just images. |
|
Yes, looks good. I retested it and it works fine 😄 |
PVince81
pushed a commit
that referenced
this pull request
Apr 30, 2014
Use FileList.files instead of DOM to get all images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of infinite scrolling, not all file entries are in the DOM.
This fix uses the FileList.files array instead.