Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADC][PWM] Improve enum name and better document Handshake for synchronous measurment. #47

Open
jalinei opened this issue May 2, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request Medium priority
Milestone

Comments

@jalinei
Copy link
Contributor

jalinei commented May 2, 2024

Following hackathon feedback :
It seems still hard to understand how to configure the external event that links ADC and PWM

Maybe a slight rework is necessary in the enum to change the naming and make it dumb proof ?

  • hrtim_ev1 and ADCTRIG_1 are not self explanatory.
  • hrtim is not self explanatory we should use MEAS_TRIG_1 or something like that
  • Both enum should be indentical on both sides.

In the documentation we need a dedicated paragraph to explain this handshake as it is not trivial.

@jalinei jalinei added documentation Improvements or additions to documentation enhancement New feature or request Medium priority labels May 2, 2024
@jalinei jalinei added this to the V1.0 milestone May 2, 2024
@cfoucher-laas
Copy link
Contributor

In addition, changing event source in Data API should also automatically configure it on the PWM side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Medium priority
Projects
None yet
Development

No branches or pull requests

4 participants