Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TWIST][PWM] Make sure TWIST PWMs are linked to the shield dts file. #49

Open
jalinei opened this issue May 2, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request Medium priority

Comments

@jalinei
Copy link
Contributor

jalinei commented May 2, 2024

Is your feature request related to a problem? Please describe.
While trying to add sync_in and sync_out subnodes to hrtim1 dts definition in spin.dts, I realized that at the moment hrtim.dtsi fragment is defined but not used.
Indeed ATM, hrtim.c file redefine everything it needs to configure hrtim using LL calls, not even using zephyr pinctrl-0 property.

Describe the enhancement you'd like

It would be interesting to define child nodes to hrtim1 dts node, one per timing unit.
As such we would have pinctrl-0 properties for each timing unit.
Interupts properties could also be spread inside timing unit child nodes.
Sync_in and Sync_out could also be defined as child nodes of hrtim1, in order to have pinctrl compatibility and suppress most of sync_master_init() / sync_slave_init() LL calls.

pinctrl-1 could be used to match different versions of shields, so that sync_in sync_out would be remapped depending on shield pinout.

Additional context
Linked to old issue : https://gitlab.laas.fr/owntech/power-api/core/-/issues/68
This issue is in my opinion tightly linked with #35 discussion as we need a way to implement generic shields using .dtsi or .overlay files somehow.

@jalinei
Copy link
Contributor Author

jalinei commented May 2, 2024

To add on top of that current hrtim.yaml does not describe hrtim.dtsi properties correctly.
https://gitlab.laas.fr/owntech/power-api/core/-/issues/69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium priority
Projects
None yet
Development

No branches or pull requests

4 participants