Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shariport-Sync shows up twice if Airplay 2 is enabled. #1578

Closed
casperghst42 opened this issue Feb 3, 2023 · 8 comments
Closed

Shariport-Sync shows up twice if Airplay 2 is enabled. #1578

casperghst42 opened this issue Feb 3, 2023 · 8 comments

Comments

@casperghst42
Copy link

Hi,

First, thank you for bringing this back to life.

I have an RPi running shairport-sync with Airplay 2 enabled, and it shows up twice as an output device. I am not sure if the problem is shairport-sync or if it is owntone.

Meaning should shairport-sync be advertising Airplay 1 when Airplay 2 is enable. Or should you combine the two devices ?

Screenshot 2023-02-03 at 21 39 11

Screenshot 2023-02-03 at 21 40 15

@ejurgensen
Copy link
Member

Thanks for the screenshot, that's important info. You can see from it that SPS is using two different device IDs, and that's why OwnTone sees them as different speakers. For AirPlay 1 (raop) the ID is 3D0968CB..., and for AirPlay 2 it is e45f0190....

@mikebrady should SPS use the same ID? That's what my ATV4 does:

$ avahi-browse -r -k _raop._tcp
...
ens33 IPv4 D0034Bxxxxxx@Speaker

$ avahi-browse -r -k _airplay._tcp
...
txt = [ ... "deviceid=D0:03:4B:xx:xx:xx" ]

@mikebrady
Copy link

Thanks for the report! Let me check this out. It may take a few days, I’m afraid.

@mikebrady
Copy link

mikebrady commented Feb 4, 2023

Thanks again for this. Your observation is correct, @ejurgensen, and that's how it used to work. It was changed to allow multiple instances of classic (i.e. AirPlay 1 only) Shairport Sync to run on the same device and have different service name prefixes. I will modify it so that the service name prefix matches the device ID in AirPlay 2 mode. It will take a few days, though...

@casperghst42
Copy link
Author

@ejurgensen thank you for the explanation and @mikebrady thank you for fixing it.

@mikebrady
Copy link

Thanks. That should be fixed now in the development branch.

Please note that if you are switching to the development branch of Shairport Sync, you must also switch to the development branch of NQPTP.

If you got a chance to check it and let us know how it goes, it would be appreciated.

@casperghst42
Copy link
Author

Thanks. That should be fixed now in the development branch.

Please note that if you are switching to the development branch of Shairport Sync, you must also switch to the development branch of NQPTP.

If you got a chance to check it and let us know how it goes, it would be appreciated.

Thank you very much, I will try to get it tested by the end of next weekend (or earlier).

@ejurgensen
Copy link
Member

Sounds good, I will close the issue here then

@casperghst42
Copy link
Author

If you got a chance to check it and let us know how it goes, it would be appreciated.

@mikebrady it works for me, the devices now only shows up once in owntone (was never a problem with macos/ios/ipados).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants