Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate Points of Interest (POI) on the map #107

Closed
jpmens opened this issue Jan 23, 2024 · 8 comments
Closed

Indicate Points of Interest (POI) on the map #107

jpmens opened this issue Jan 23, 2024 · 8 comments
Labels
Status: Done Feature has been implemented, bug fixed, question answered etc. Type: Feature New feature

Comments

@jpmens
Copy link
Member

jpmens commented Jan 23, 2024

As a proof of concept, our OwnTracks iOS app is able to submit a Point of Interest (POI) upon manually publishing a location from the UI. The app displays these POI on its map.

poi

This POI is added to the JSON payload (element: poi), and as with all elements therein, surfaced by Recorder in the API:

{
      "_type": "location",
      "lat": 17.065921,
      "lon": -96.717023,
      "poi": "Oaxaca, hotel Los Pilares",
      "t": "u",
      "tid": "jp",
      "tst": 1703040222,
     ...
}

It seems to me a good idea to have these POI indicated in the Frontend as well.

@jpmens jpmens added the Type: Feature New feature label Jan 23, 2024
@linusg
Copy link
Member

linusg commented Jan 23, 2024

ACK, keeping up with new features provided by the app(s) seems desirable - I'll look into this 👍

@linusg linusg added the Status: Accepted This seems to be a good idea and someone should start working on it label Jan 23, 2024
@jpmens
Copy link
Member Author

jpmens commented Jan 23, 2024

I'm not particularly fond of shape nor colour combinations, but this is how http://umap.openstreetmap.fr places the label on a geoJSON feature:

rabbit-10637

@ykram
Copy link

ykram commented Jun 1, 2024

Glad to see a feature request was raised for this. I have several POIs submitted but wish I could see these on the front end map.

@jpmens
Copy link
Member Author

jpmens commented Jun 1, 2024

Until that is implemented there's a bit of a workaround (not using Frontend) as detailed in owntracks/recorder#439

@linusg linusg added Status: In progress Someone's currently working on this and removed Status: Accepted This seems to be a good idea and someone should start working on it labels Jun 10, 2024
@linusg
Copy link
Member

linusg commented Jun 10, 2024

@jpmens how do you like this?

image

@jpmens
Copy link
Member Author

jpmens commented Jun 10, 2024

@linusg that is gorgeous. SHIP IT! ☺️

@linusg linusg closed this as completed in 554ce3f Jun 10, 2024
@linusg linusg added Status: Done Feature has been implemented, bug fixed, question answered etc. and removed Status: In progress Someone's currently working on this labels Jun 10, 2024
@linusg
Copy link
Member

linusg commented Jun 10, 2024

@jpmens
Copy link
Member Author

jpmens commented Jun 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done Feature has been implemented, bug fixed, question answered etc. Type: Feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants