Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with logging when no TTY present #408

Closed
tobru opened this issue Mar 31, 2023 · 4 comments
Closed

Issues with logging when no TTY present #408

tobru opened this issue Mar 31, 2023 · 4 comments

Comments

@tobru
Copy link

tobru commented Mar 31, 2023

The change (aka magic) introduced in d673de8 caused a little headache. I'm running the recorder on Kubernetes (yes, absolutely works fine) and recently upgraded to the latest recorder version. Suddenly, no logs appeared anymore, and I was searching like hell what the issue could be. I even wondered if the earth started to rotate the other way around 🌍

Turns out: By default there is no TTY when running a process in a Kubernetes Pod and also no syslog facility. Because of that, no logs appeared. After setting tty: true on the Pod spec, the logs appeared again. Yay.

May I propose to remove this magic from recorder and introduce a command line flag to explicitely configure the log destination? Either stdout or syslog. I ❤️ being explicit, rather than assumption based.

That would be awesome 🎈

@jpmens
Copy link
Member

jpmens commented Apr 1, 2023

You seem to have solved the problem with setting tty: true so at best we'll put this on the back burner; I can't imagine there are many people running the Recorder on Kubernetes ... ;)

@tobru
Copy link
Author

tobru commented Apr 1, 2023

Thanks for taking care of my issue 👍 I agree that there is no need for a hurry, especially because a workaround exists. And at least it's documented now in this issue, so should there be any other stranger out there running recorder on Kubernetes, it's here.

@jpmens
Copy link
Member

jpmens commented Oct 24, 2023

@tobru I think we've now fixed this in #426

Feel free to reopen if it doesn't work for you.

@jpmens jpmens closed this as completed Oct 24, 2023
@tobru
Copy link
Author

tobru commented Oct 24, 2023

I confirm that I could remove the tty: true workaround in the Pod spec and still get logs. Thanks a lot for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants