-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oxc_traverse: cannot publish the build script #3280
Comments
Hmm. Not sure how to solve this. I assume problem is that it requires NodeJS be installed (which is one reason I disabled it from running on CI). Ultimate solution is to re-write it in Rust. But it's useful to have it in JS for time being while Have you got link to the CI run which failed before you renamed the build script? I don't know how the publish workflow works. |
Boshen also mentioned elsewhere that the build script is adding ~18 secs to compile times. I think we should tackle this as follows:
@Boshen Does that sound like a good approach to you? |
Sounds good to me, leave this to me. |
Fixed, we don't need to publish build.rs oxc/crates/oxc_traverse/Cargo.toml Line 14 in b09092c
|
Does that ensure that the build script has been run locally and |
Our CI pipeline disallows publishing untracked files, and I run |
I had to nuke the build script and revert it back
6d63f99#diff-cb940282a3e680adf99d07ea6f52e94c5131d9e68153c8510abcecd6d166ceb9
482dcc0
This is not urgent, but should be resolved before the next release, probably when transformer milestone 1 is done.
The text was updated successfully, but these errors were encountered: