Skip to content

Commit

Permalink
Remove postfix_master confine on EOL postfix version
Browse files Browse the repository at this point in the history
The binary used by the postfix_master provider was introduced only in
postfix v2.11, which is why the provider was confined to this version.

However, this causes trouble on initial run, when the package is not yet
installed. Since postfix 2.11 is already EOL anyway, the easiest fix is
to removed the confine.

Patch provided by Craig Watson (see #10).

Fixes #9.
  • Loading branch information
oxc committed Nov 27, 2018
1 parent 3e30c76 commit e05339f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Changed
- Remove the confine on EOL postfix version for postconf_master provider ([#9])

## Release [1.0.2] - 2018-10-28
This release fixes postfix reloading on config changes.
Expand Down Expand Up @@ -80,6 +82,7 @@ First release as oxc-postfix, now requires Puppet 4.9
[0.2.0]: https://github.com/oxc/puppet-postfix/compare/v0.1.0...v0.2.0
[0.1.0]: https://github.com/oxc/puppet-postfix/compare/v0.0.1...v0.1.0
[0.0.1]: https://github.com/oxc/puppet-postfix/compare/f7d8b52...v0.0.1
[#9]: https://github.com/oxc/puppet-postfix/issues/9
[#7]: https://github.com/oxc/puppet-postfix/issues/7
[#6]: https://github.com/oxc/puppet-postfix/pull/6
[#5]: https://github.com/oxc/puppet-postfix/issues/5
Expand Down
1 change: 0 additions & 1 deletion lib/puppet/provider/postconf_master/postconf.rb
@@ -1,7 +1,6 @@
require File.expand_path(File.join(File.dirname(__FILE__), '..', 'postconf'))

Puppet::Type.type(:postconf_master).provide(:postconf, parent: Puppet::Provider::Postconf) do
confine postfixversion: '2.11'

def self.instances
postfix_instances.map { |instance, path|
Expand Down

0 comments on commit e05339f

Please sign in to comment.