Downgrade required libuv version to 1.18 #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestrate
approved these changes
Jan 18, 2021
(1.18 is the version found in bionic).
jagerman
force-pushed
the
downgrade-required-libuv-version
branch
from
0bc21e4
to
e416be7
Compare
jagerman
force-pushed
the
downgrade-required-libuv-version
branch
from
e416be7
to
60a267a
Compare
We set CMAKE_CROSSCOMPILE in a few places, but that is just a typo for CMAKE_CROSSCOMPILING. However we don't need to set it at all: cmake does so automatically whenever CMAKE_SYSTEM_NAME is set (which is why our cross compiling actually works currently.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1.18 is the version found in bionic).