Bencode formats

[neuroscr]

Missing keys should be FATAL

Extra keys (possible old format that's now deprecated) should be a WARN

[majestrate]

ideally we need to implement seek/discard of entities instead of just hard failing if they are not the expected format.

[majestrate]

idea, have llarp::IBEncodeMessage have a member for unrecondised values

[majestrate]

specifically a std::unordered_map<std::string, llarp_buffer_t> where key is the key name and value is a buffer containing its value.

[majestrate]

or.... potentially pass into llarp::IBEncodeMessage::BDecode a std::unordered_map<std::string, llarp_buffer_t> & to place in unknown fields.

[neuroscr]

why would we need to store fields we don't know or can't do anything with in memory? Seems just like a waste of memory.

[majestrate]

it's not, it's a llarp_buffer_t which is a pointer to a region of memory, it doesn't copy it.

[majestrate]

oh, right, it's for older version to not die when parsing newer messages

[neuroscr]

closing because no one cares any more