Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send uptime proof until we've heard from the storage server #871

Closed
jagerman opened this issue Oct 7, 2019 · 4 comments
Closed

Don't send uptime proof until we've heard from the storage server #871

jagerman opened this issue Oct 7, 2019 · 4 comments

Comments

@jagerman
Copy link
Member

jagerman commented Oct 7, 2019

We send an uptime proof initially (IIRC for the first hour) without having heard from the storage server, but this can mislead operators who think everything is working right because an uptime proof goes out.

Since the storage server pings quite frequently, I think we should require such a ping before sending any uptime proof.

@jagerman
Copy link
Member Author

jagerman commented Oct 7, 2019

Also I think we can add to the new lokid status line for SNs a "NO STORAGE SERVER" status when we haven't heard from it.

@Doy-lee
Copy link
Collaborator

Doy-lee commented Oct 7, 2019

This sounds reasonable given there's evidence of this biting operators during the setup process. Initially the concern was that the 5 minutes in between checks or whatever the duration was too long to wait at startup, but this can be worked around by adding an uptime proof check after the first initial ping from storage server.

@jagerman
Copy link
Member Author

jagerman commented Oct 7, 2019

There's already a 5 minute delay now (the uptime proof runs every 5 minutes and things are usually not ready when the first one fires), so I don't think we'd delay things. But if the ping could trigger a proof going out that would actually improve things.

@jagerman
Copy link
Member Author

Fixed in #874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants