Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction log does not indicate unsuccessful stakes #265

Open
buccella opened this issue Mar 28, 2021 · 0 comments
Open

Transaction log does not indicate unsuccessful stakes #265

buccella opened this issue Mar 28, 2021 · 0 comments

Comments

@buccella
Copy link

The transaction log shows all staking transactions the same, whether they were successful or not.

Example
Block 761279 includes two transactions, both contributions to snode ...a3d5. The node had one contributor spot open to be filled.

The first contribution transaction of the block is from contributor ...THcD.
The second contribution transaction of the block is from contributor ...B5Yx.

We can see from snode's contributors list that the contribution from ThcD edged out the one from B5Yx. ThcD became contributor 4/4.

In the wallet, both THcD and B5Yx will show a confirmed staking transaction. The unlocked balance for both will be accurate, and B5Yx won't show a stake under "My Stakes". However, the staking transaction will show in the transaction history, with no indication that the stake was not confirmed; it looks the same as a successful stake. Transaction details also look the same as a successful stake.

Fix
I'm not sure what the best fix for this is. The unsuccessful staking by B5Yx isn't a transaction itself, so a "failed staking" entry in the transaction log wouldn't exist.
Perhaps just changing the label in the transaction log from "Stake" to "Stake Attempt" would be less confusing for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant