Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P does not recover after 1 failed message #192

Closed
sachaaaaa opened this issue Feb 12, 2019 · 2 comments · Fixed by #203
Closed

P2P does not recover after 1 failed message #192

sachaaaaa opened this issue Feb 12, 2019 · 2 comments · Fixed by #203
Labels
bug Something isn't working

Comments

@sachaaaaa
Copy link

Currently we set a contact as offline as soon as we fail to send him 1 message via P2P.
Once marked as offline, we have no way to restore the P2P session unless one of the two participants restart their application, which would send a broadcast message.

When we are online, we currently only send a broadcast message (or ping) to our online contacts. Maybe we should attempt sending a ping to all contacts for which we have a .loki address stored in memory.

@sachaaaaa sachaaaaa added the bug Something isn't working label Feb 12, 2019
@sachaaaaa sachaaaaa added this to To do in DEPRECIATED Loki Messenger via automation Feb 12, 2019
@Mikunj
Copy link

Mikunj commented Feb 12, 2019

could we compare timestamps in the message received and if we see that it's within a certain time frame i.e 1 minute then we can mark that person as online and we send them the ping?

@BeaudanBrown
Copy link

We could but this would still require that someone messages someone before they will be marked online again
A naive approach I can think of is sending broadcast messages with tll of 1 minute to all your offline contacts over storage server every minute but feels pretty brute force?

DEPRECIATED Loki Messenger automation moved this from To do to Done Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants