Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault when turning off scaling and the matrices are updated #49

Closed
GiulioRomualdi opened this issue Feb 20, 2018 · 1 comment

Comments

@GiulioRomualdi
Copy link

GiulioRomualdi commented Feb 20, 2018

If the number of scaling iteration is set to 0 a segmentation fault occurs when the hessian P or/and the linear constraints matrix A are updated.
You can verify the issue adding the following line here

settings->scaling = 0;

I think that the problem is caused to the calling of the scale_data() and unscale_data() methods in the osqp_update_*() functions. In this case it can be easily solved adding an if statement

if(work->settings->scaling){
    scale_data(work);
}
@GiulioRomualdi GiulioRomualdi changed the title Segmentation fault when turning off scaling in C and the matrices are updated Segmentation fault when turning off scaling and the matrices are updated Feb 20, 2018
@bstellato
Copy link
Collaborator

Thank you for letting us know. I will fix it.

OSQP v1.0 development automation moved this from To Do to Done Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants