Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a header containing the private QDLDL config options #37

Merged
merged 4 commits into from Sep 30, 2021

Conversation

imciner2
Copy link
Member

@imciner2 imciner2 commented Feb 3, 2021

This is the first half of a fix to make the qdldl-python package work. Basically, that package needs access to the DLONG define that the QDLDL sources use for defining their integer types, so this commit writes out that information into a standalone configure header (similar to the way it is done in OSQP).

@coveralls
Copy link

coveralls commented Feb 3, 2021

Pull Request Test Coverage Report for Build 174

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 170: 0.0%
Covered Lines: 87
Relevant Lines: 87

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 10, 2021

Pull Request Test Coverage Report for Build 1290796522

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1221906610: 0.0%
Covered Lines: 87
Relevant Lines: 87

💛 - Coveralls

@bstellato
Copy link
Collaborator

Thanks for making that change. Just a minor comment, how about putting these new lines together with the qdldl_types.h.in file? I am not sure we need two separate files for doing something very closely related.

@imciner2
Copy link
Member Author

Ok, I have changed this to write the two configuration defines into the existing qdldl_types.h header that we generate, and have also namespaced them into QDLDL_* so that we don't leak them into other applications (such as OSQP when we include the QDLDL headers).

@bstellato bstellato merged commit c662639 into osqp:master Sep 30, 2021
@imciner2 imciner2 deleted the im/confheader branch September 30, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants