Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force REPLY type definitions into DWARF #23

Merged
merged 1 commit into from Sep 3, 2022
Merged

Conversation

bcantrill
Copy link
Contributor

@bcantrill bcantrill commented Aug 29, 2022

Draft comment:

The DWARF generated for types is load-bearing in that Humility
potentially needs them to be able to form arguments to Idol calls and
to make sense of the reply.  But if an Idol server is declared without
a consuming Idol client, any synthetic reply type won't be generated.
This work forces any synthetic reply type definition to be generated
by creating a meaningless static (that itself will be optimized away),
which has the side-effect of getting the type that we need in the
binary (but without changing the generated text or data).

Copy link
Contributor

@mkeeter mkeeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@bcantrill bcantrill merged commit 7350b8a into main Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants