Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropRef and its consumers should be safer #515

Open
FelixMcFelix opened this issue Apr 26, 2024 · 0 comments
Open

DropRef and its consumers should be safer #515

FelixMcFelix opened this issue Apr 26, 2024 · 0 comments
Labels
cleanup Code cleanliness good first issue

Comments

@FelixMcFelix
Copy link
Collaborator

We currently have a few 'safe' wrappers around reference release functions used by next_hop and the DropRef machinery:

fn ire_refrele(ire: *mut ip::ire_t) {
    unsafe { ip::ire_refrele(ire) }
}

We should revisit this by matching Arg to its cleanup function, using an unsafe trait or similar mechanism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code cleanliness good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FelixMcFelix