You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In short, a schemars fix to put doc comments on enum variants caused dropshot to change some simple enum schemas to oneOfs of single-item enums, changing this
Fortunately the inferred type ends up the same, and I think in practice the runtime behavior is also the same. So we don't necessarily have to convert this back to what it was before, though it would be neater. It would be nice to pull in the newly available comments on each variant, though.
In 59c40a1 we pull in changes from the following chain of PRs:
oxidecomputer/omicron#1789
oxidecomputer/dropshot#454
GREsau/schemars#152
In short, a
schemars
fix to put doc comments on enum variants caused dropshot to change some simpleenum
schemas tooneOf
s of single-itemenums
, changing thisoxide.ts/client/Api.ts
Lines 519 to 530 in 45ead9d
to this
oxide.ts/client/Api.ts
Lines 520 to 531 in 59c40a1
Fortunately the inferred type ends up the same, and I think in practice the runtime behavior is also the same. So we don't necessarily have to convert this back to what it was before, though it would be neater. It would be nice to pull in the newly available comments on each variant, though.
https://github.com/oxidecomputer/omicron/blob/74f3ca89af11b0ce6d9f9bd4b5bdcbeb04d1ba3e/openapi/nexus.json#L9098-L9114
The text was updated successfully, but these errors were encountered: