Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcvradm flags could be better #49

Open
bnaecker opened this issue Dec 22, 2022 · 0 comments
Open

xcvradm flags could be better #49

bnaecker opened this issue Dec 22, 2022 · 0 comments

Comments

@bnaecker
Copy link
Collaborator

The xcvradm flags for read/write operations currently require that the caller specify the kind of memory map for the module. E.g., xcvradm -i igb0 read-lower --sff 0 4 to read the first four bytes of an SFF-8636 module. That is enforced in teh argument parsing and used here to construct a Memory{Read,Write} of the correct kind. That's OK, but it's not really necessary. We could instead fetch the management interface for the addressed modules, and create the memory access of the right kind depending on what we get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant