Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional build-time package dependencies #316

Open
taylorthurlow opened this issue Jan 16, 2024 · 6 comments
Open

Additional build-time package dependencies #316

taylorthurlow opened this issue Jan 16, 2024 · 6 comments

Comments

@taylorthurlow
Copy link

I'm in need of libssl-dev for cross-compile targets like x86_64-linux, but I don't see any obvious way to include them in the build step.

@ianks
Copy link
Collaborator

ianks commented Jan 16, 2024

For the openssl crate, you should be able to use the vendored feature. Let me know if that works.

@taylorthurlow
Copy link
Author

taylorthurlow commented Jan 17, 2024

In this case I have a dependency on jsonschema which, in order to support a particular part of the library, requires me to add a dependency on reqwest with the rustls-tls feature enabled, which requires the SSL libs.

I'm super green on Rust (I live in Ruby land, probably unsurprisingly) - but am I mistaken in thinking that required external package dependencies would be a common issue in this case?

@ianks
Copy link
Collaborator

ianks commented Jan 17, 2024

I'm pretty sure rustls would not require the ssl libs at all, since it's a pure rust dependency... either way, if you add:

openssl = { version = "*", features = ["vendored"] }

that will make it so the ssl libs are always vendored for all deps.

@ianks
Copy link
Collaborator

ianks commented Jan 17, 2024

Looking at the gem now, try native-tls-vendored as well

@ianks
Copy link
Collaborator

ianks commented Jan 17, 2024

Also, you may be able to use rustls still, i think you would need to set default-features = false on reqwest (otherwise it will try to use openssl)

sorry for the spam

@taylorthurlow
Copy link
Author

Feel free to take a look at the failed action run if you are interested in the build failure. 3 of the 6 build targets failed, I rolled back the dependency change and things were back to normal.

Regardless, though, I appreciate the suggestions, I will give them a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants