-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional flag for RegisterDataDep for post_fetch_cleanup #14
Comments
There is an argument to be made that this can already be achieved by adding an |
Actually, now that I think about it the following isn't that bad and it works. Also, looking at the code for post_fetch_method = file -> (run(BinDeps.unpack_cmd(file,dirname(file), ".gz", ".tar")); rm(file)) I'll leave this issue open in case you have some opinion on this. otherwise feel free to close |
I was thinking about something similar to this initially. The way I was initially thinking of doing it was by including a helper a function: Related would be to allow Another would be to include a helper a function like Yet another option would be to include helper functions, like: |
Done> |
I think it could be nice to have an additional optional named flag for
RegisterDataDep
that could signal to DataDeps that after executing thepost_fetch_method
the downloaded files should be deleted. Maybe something likepost_fetch_cleanup = true
which defaults tofalse
. This way the data for something like CIFAR-10 isn't kept around twice (once as the archive and once as the unpacked files)This should work well with #10 (comment)
The text was updated successfully, but these errors were encountered: