Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback from just DOI to https://dx.doi.org/<DOI> ? #63

Open
oxinabox opened this issue Sep 27, 2018 · 0 comments
Open

Fallback from just DOI to https://dx.doi.org/<DOI> ? #63

oxinabox opened this issue Sep 27, 2018 · 0 comments

Comments

@oxinabox
Copy link
Owner

I'm not 100% sure on this,

but I think if you call the general generate, without specifying a repository,
and passing in a DOI,

possibly we should also check the results for if the URL:
https://dx.doi.org/<DOI>
had been passed instead.
And even expand that URL into it's final form after all the redirects complete.
Because that would work with more of the providers.

I am not sure what the best way to do this is.

It might be as an explict thing done in the generate function.
Or it might be done in some providers (like JSONLD_Web) if they are passed as DOI (rather than an URL),
in get_mainpage.
Or it might be that we make a wrapping provider type / macro decorator
to to that to multiple providers.

It would be good to have a test case showing this being useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant