Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade hadolint to >=2.9.2 #1367

Closed
DrYak opened this issue Mar 29, 2022 · 2 comments · Fixed by #1370
Closed

Please upgrade hadolint to >=2.9.2 #1367

DrYak opened this issue Mar 29, 2022 · 2 comments · Fixed by #1370
Labels
bug Something isn't working

Comments

@DrYak
Copy link

DrYak commented Mar 29, 2022

Describe the bug
The version 2.9.1 used by the latest Megalinter is affected by bug 785: false positive on pragmas.

To Reproduce
Dockerfile starting with a syntax pragma, for example:

# syntax=docker/dockerfile:1.3
ARG test=val
FROM debian:stable
…etc…

Expected behavior
versions <=2.9.0 (predating the bug) and >=2.9.2 (which contains the fix) correctly recognize the above as valid (it only has comments (with pragma), and ARG until the FROM section begins).

Screenshots
Version 2.9.1 triggers this false positive instead:

DL3061 error: Invalid instruction order. Dockerfile must begin with FROM, ARG or comment.

Additional context
We use mega-linter to automatically check our bioinformatics pipeline and it is affected by this bug as current megalinter uses the affected version 2.9.0 of hadolint.

@DrYak DrYak added the bug Something isn't working label Mar 29, 2022
@nvuillam
Copy link
Member

Understood, this will be done very soon in beta, and not so long after in latest :)

@nvuillam
Copy link
Member

It's on the way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants