Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Docker Container Names in pre-commit hooks #1932

Closed
mwarres opened this issue Oct 5, 2022 · 0 comments · Fixed by #1933
Closed

Invalid Docker Container Names in pre-commit hooks #1932

mwarres opened this issue Oct 5, 2022 · 0 comments · Fixed by #1933
Labels
bug Something isn't working

Comments

@mwarres
Copy link
Contributor

mwarres commented Oct 5, 2022

The Docker container names in .pre-commit-hooks.yaml contain Bash syntax, which pre-commit interprets as string literals, resulting in invalid Docker container names.

Fixed for our repository in ScribeMD/pre-commit-hooks#110.

Will provide fix.
@mwarres mwarres added the bug Something isn't working label Oct 5, 2022
@mwarres mwarres mentioned this issue Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Docker container names in pre-commit hooks mwarres/megalinter
1 participant
@mwarres