Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reach via twitter #208

Closed
jlongman opened this issue Dec 31, 2020 · 2 comments
Closed

Can't reach via twitter #208

jlongman opened this issue Dec 31, 2020 · 2 comments
Labels
O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity question Further information is requested

Comments

@jlongman
Copy link

jlongman commented Dec 31, 2020

First, tried to say hi via the blue bird but the "This account doesn't exist". It's linked in the footer of your doc home page:

Expectation: Either a valid twitter account should be linked or the link should be removed. Is there a valid twitter account?

What I was trying to say was: Super happy to find this project as I've run up against the limitations of the bash version when adapting it for bitbucket, and to a lesser degree codebuild. Additionally in my port of the super-linter I parse the linter annotations and make line-by-line annotations against the bitbucekt PR api (for example) as well as adding xunit output.

Also thrilled to see flavors and am curious about docker-in-docker as a solution for certain environments. I've still not scanned the docs but I'm hoping the flavors still detect all formats and warn or fail if the flavor is incomplete and/or a separate lightweight image can do that.

Great stuff, hoping to throw up a PR soon (but I must admit this is a bit shaving the yak for me).

@jlongman jlongman added the question Further information is requested label Dec 31, 2020
@nvuillam
Copy link
Member

nvuillam commented Dec 31, 2020

Hi, thanks a lot for the feedback, I just corrected my twitter link, which is https://twitter.com/NicolasVuillamy :)

I see you played with BitBucket... would you make a tiny PR in the README so I can add it in the list of installation CI systems ? ( then later in the config generator). Or just paste here your bitbucket workflow configuration and I'll do the rest :)

I don't get exactly what you do with super-linter logs, but it seems about detailed reporters, so I'm sure that we can do more with Mega-Linter reporters:

  • maybe a new BitBucketCommentReporter ? or something more ? Reporters architecture allow to have as many as we want, so your PR would be very welcome :)
  • building a reviewDog reporter ... maybe it would help with your requirement ? ( I see they have a BitBucket reporter )

About flavors, it's not "docker in docker", it's just different images with less linters according to the project requirement.

Mega-Linter runtime architecture:

  • detects if the wrong flavor is used (meaning some files can't be linted) and displays a big warning message
  • suggests to use a smaller flavor in case the selected one contains too many linters for what it does

Please let me know your thoughts, and thanks again for your interest 🚀

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants