Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media controls on lockscreen not properly showing #20

Closed
1 task done
ghost opened this issue May 30, 2021 · 5 comments
Closed
1 task done

Media controls on lockscreen not properly showing #20

ghost opened this issue May 30, 2021 · 5 comments
Labels
bug Something isn't working device-specific Problem is specific to a device type

Comments

@ghost
Copy link

ghost commented May 30, 2021

Describe the bug/crash:

Media player controls & info not properly working on lockscreen (instead it shows up in a notification)

Steps To Reproduce the bug/crash:

  1. Open Auxio and play some music
  2. Lock then open the screen
  3. Lockscreen says that it doesn't detect a music player.

Screenshots:

Screenshot_20210531-025515

Phone Information:

Device: Samsung Galaxy J2 2015 (j2lte)
Android version: 7.1.1 (Custom Samsung ROM)

Due Diligence:

I have been looking for a good FOSS music player and I came across this one. Really liking it :) It's simple but functional. I'll be using it as my daily use audio player and post bugs that I may come across, like this one.

@ghost ghost added the bug Something isn't working label May 30, 2021
@OxygenCobalt
Copy link
Owner

Most of these "Control music from the lockscreen" systems use the MediaSession API, and I'm aware that there may be some issues with the way I'm currently implementing it. I'll try to look into it.

@OxygenCobalt OxygenCobalt added the device-specific Problem is specific to a device type label May 30, 2021
@OxygenCobalt
Copy link
Owner

I've located the issue, my implementation of MediaSession is too sparse and does not signal that it supports play/pause/skip actions, hence why it does now show up. I'll try to implement those changes and come back to you eventually.

OxygenCobalt added a commit that referenced this issue Jun 1, 2021
Add event handling to the MediaSession. This completes the new
PlaybackSessionConnector class and possibly addresses the issue raised
in #20.
@OxygenCobalt
Copy link
Owner

Can you try this APK? I think I've set it up so that the lock screen can detect it.
app-debug.zip

@ghost
Copy link
Author

ghost commented Jun 3, 2021

Screenshot_20210603-234244

It works :)

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Jun 3, 2021

Great, I'll mark this issue as resolved then. This fix should arrive in 1.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working device-specific Problem is specific to a device type
Projects
None yet
Development

No branches or pull requests

1 participant