Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback bottom sheet flickers on warm start #631

Closed
OxygenCobalt opened this issue Dec 3, 2023 · 2 comments
Closed

Playback bottom sheet flickers on warm start #631

OxygenCobalt opened this issue Dec 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working non-criticial Will fix later ui Related to app UI

Comments

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Dec 3, 2023

It's a bit hard to describe, but when you warm start Auxio (i.e service active but activity was killed), the bottom sheet flickers from it's default expanded state to it's correct collapsed state. I thought I fixed this, but oh well. Bottom sheet component try not to break spontaneously for no reason challenge (impossible)

@OxygenCobalt OxygenCobalt added bug Something isn't working ui Related to app UI labels Dec 3, 2023
@OxygenCobalt OxygenCobalt changed the title Bottom sheet flickers on warm start Playback bottom sheet flickers on warm start Dec 3, 2023
@OxygenCobalt
Copy link
Owner Author

Believe this is caused by a race condition where the bottom sheet is laid out before the playback bar has correct dimension information, which prevents the correct peek height being set until a little bit later, in which the bottom sheet will assume it's default auto peek height configuration instead. Not sure what I can do about it.

@OxygenCobalt
Copy link
Owner Author

OxygenCobalt commented Dec 3, 2023

@OxygenCobalt OxygenCobalt self-assigned this Dec 21, 2023
@OxygenCobalt OxygenCobalt added the non-criticial Will fix later label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-criticial Will fix later ui Related to app UI
Projects
Status: v4.0.0
Development

No branches or pull requests

1 participant