Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub actions for CI? #51

Closed
Phanabani opened this issue Oct 11, 2022 · 2 comments
Closed

Use GitHub actions for CI? #51

Phanabani opened this issue Oct 11, 2022 · 2 comments
Assignees
@Phanabani
Labels
change A change to an existing feature internal An internal change that users shouldn't be aware of Need Answer

Comments

@Phanabani
Copy link
Collaborator

Phanabani commented Oct 11, 2022 •
edited

Hey @oxyno-zeta!

Following our discussion in #49, I've added a GitHub action in change/use-github-actions to test builds, rather than using CircleCI. Here is the successful result of the action.

Would you like for me to merge this into 2.3.0, using GitHub actions for CI instead of Circle?

If yes, I'll just need you to remove Circle from tracking this repo so we don't see its failed attempted builds!
@Phanabani Phanabani added Need Answer change A change to an existing feature internal An internal change that users shouldn't be aware of labels Oct 11, 2022
@Phanabani Phanabani self-assigned this Oct 11, 2022
@Phanabani Phanabani changed the title Use GitHub actions for build tests? Use GitHub actions for CI? Oct 11, 2022
@oxyno-zeta
Copy link
Owner

Hello,

You can ! That's not a requirement for me in itself. The only requirement was to have a CI working ! :)
You did it well on 2.3.0 branch.
As you want ! ;)

Regards,

Oxyno-zeta

@Phanabani
Copy link
Collaborator Author

I will use GitHub actions! Gonna merge it into 2.3.0 😊

@Phanabani Phanabani mentioned this issue Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phanabani Phanabani

Labels
change A change to an existing feature internal An internal change that users shouldn't be aware of Need Answer
Projects
React Editable JSON Tree v2.3.0
Status: Done
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

change/use-github-actions oxyno-zeta/react-editable-json-tree
2 participants
@oxyno-zeta @Phanabani