-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WindowsForms PlotView based on SkiaSharp #1516
Comments
Given this would have to write to a buffer and copy/swap, the rendering engine could be abstracted away completely. There is no reason e.g. the ImageSharp renderer could be swapped in as well. I had a go with Skia and ran into a couple of rendering issues (apart from hating the abstraction I built), but if this would be an acceptable design I would be happy to do the leg work. My first attempt (a bit out of date) can be found here: develop...VisualMelon:WinFormsSkia I'd envisage adding an The advantages of such a design would be:
Obvious concerns
If we aren't sure this is bad idea yet, I'm equally happy to do the leg work so we can decide how much we hate it once it is working. |
Just a thought on the question of whether additional renderers would be a good idea: yes: at the moment, it is a miserable experience reviewing the outputs of e.g. |
Interesting thought! It would for sure be nice to be able to view ImageSharp-rendered Plots in the ExampleBrowser. I guess it would be nice to have this We can probably not use the hardware acceleration SkiaSharp offers this way, but I don't think this is a huge concern for now. As far as I know, render time is mostly dominated by transformations etc. in the plot model itself, not the actual rendering of the shapes. |
It looks like |
I haven't really done much with Alternatively we could keep this as is and create a new |
@Jonarw yeah, thinking about it that would be a much better idea, and would mean I can get on with implementing everything rather than trying to make decisions I can't make. |
@VisualMelon @Jonarw it would be interesting to have an implementaion of this kind, mainly with graphic accelleration with opentk. Do you still take in consideration this develop ? Thank you |
UPDATE: I have implemented the skiasharp with GL on oxyplot libraries, but i noticed that in a performance comparison,rendering is slower than simple system.drawing or skiasharp implemented by you @VisualMelon. I'm still investigating to understand why.. i'm keeping updated this thread. |
As it has been years since I last worked with WindowsForms, if someone else feels like taking on this task, please go ahead.
Things to consider:
OxyPlot.WindowsForms
?The text was updated successfully, but these errors were encountered: