turning off 'past' campaigns by default in /campaigns API

mozilla · Oct 28, 2015 · 192fa3f · 192fa3f
1 parent 0cec7a0
commit 192fa3f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/splice/web/api/campaign.py b/splice/web/api/campaign.py
@@ -50,7 +50,7 @@ def __init__(self):
         self.reqparse_get = reqparse.RequestParser()
         self.reqparse_get.add_argument('account_id', type=int, required=True, help='Account ID', location='args')
         self.reqparse_get.add_argument('past', type=inputs.boolean, required=False,
-                                       help='Campaigns that ran in the past', location='args', default=True)
+                                       help='Campaigns that ran in the past', location='args', default=False)
         self.reqparse_get.add_argument('in_flight', type=inputs.boolean, required=False,
                                        help='Campaigns currently running', location='args', default=True)
         self.reqparse_get.add_argument('scheduled', type=inputs.boolean, required=False,

diff --git a/tests/api/test_campaign.py b/tests/api/test_campaign.py
@@ -54,7 +54,7 @@ def test_get_campaigns_by_account_id(self):
         # Verify two accounts are returned.
         for account_id, campaigns in self.campaign_fixture.iteritems():
             url = url_for('api.campaign.campaigns')
-            url = url + '?account_id=%s' % account_id
+            url = url + '?account_id=%s&past=True' % account_id
             response = self.client.get(url)
             assert_equal(response.status_code, 200)
             resp = json.loads(response.data)