Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in the 'python' directory #4

Open
oysteijo opened this issue May 2, 2019 · 3 comments
Open

Cleanup in the 'python' directory #4

oysteijo opened this issue May 2, 2019 · 3 comments
Assignees
Labels
Refactor/Cleanup Just a label for technical dept and refactorisation proposals and general code cleanup.

Comments

@oysteijo
Copy link
Owner

oysteijo commented May 2, 2019

The python directory contains code for comparing the python reference with keras in addition to a script for comparing the python reference the C implementation. This code is a bit of a mess. Code is repeated in the two scrips and the config dictionary is not properly used. etc. Basically, it just needs a cleanup.

@oysteijo oysteijo self-assigned this May 2, 2019
@oysteijo oysteijo added the Refactor/Cleanup Just a label for technical dept and refactorisation proposals and general code cleanup. label May 2, 2019
@oysteijo
Copy link
Owner Author

Maybe the directory it self should be called reference and then the neural network implementation can be called neuralnet.py?

@oysteijo
Copy link
Owner Author

After I changed the neuralnet store format, The python implementation was not updated accordingly. Fix this first!

@oysteijo
Copy link
Owner Author

oysteijo commented Aug 15, 2022

May we can extract the python implementation to a project on it's own? If we need to verify the C implementation, that can be done with keras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor/Cleanup Just a label for technical dept and refactorisation proposals and general code cleanup.
Projects
None yet
Development

No branches or pull requests

1 participant