Introducing two new config parameters #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wneessen
commented
Mar 23, 2021
wneessen
commented
- TZ_LOCAL_NAME: allows to override the display of "Local" with a name of coice
- TZ_24H: allows to display the header time in 24h format instead of 12h format
Using the TZ_LOCAL_NAME environment variable, one can override the display name of the "Local" timezone I am currently in.
Using the TZ_24H environment variable, one can override the default time display format of 12h format and use the 24h format instead
TZ_LOCAL_NAME was only working when TZ_LIST was defined
|
This is a nice improvement, but I feel that it is at odd with issue #1, where we could make these preferences into configuration options or flags. Mostly, I'd like the number of env. variables to range from 0 to 2, but not higher. |
|
Understood. Out of curiosity, would it be of any interest if I implement basic configuration via optional flags? |
|
Yes, I think that flags could be fine for this. :)
…
Understood. Out of curiosity, would it be of any interest if I implement basic configuration via optional flags?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub (#13 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAACJXEOEYODAP7LMRY2NFLTFGEN7ANCNFSM4ZWAEQCQ).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.