New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ♭ in accidental regex #3

Closed

majg0 opened this issue Feb 2, 2020 · 2 comments

majg0 commented Feb 2, 2020

rust-music-theory/src/note/pitch_class.rs

Line 70 in 12983c2

'b' | '♭' => {

Could be nice when copy pasting, so I vouch to keep check and add in regex, instead of removing.

Owner

ozankasikci commented Feb 3, 2020

@martingronlund that makes sense, could you please open a PR for this? Otherwise i will implement it.

Owner

ozankasikci commented Feb 5, 2020

added here, closing.

ozankasikci closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment