-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chinese Names and Surnames #4
Comments
Hello @ozdemirburak , could i please be assigned to this task? Thank you so much. |
Sure, actually, there's no need to ask. As long as anyone follows the guidelines, I'm OK with merging any pull request. |
@ozdemirburak I made two pull requests because I wasn't sure exactly how to merge them, is there a way I can merge the two pull request together so they're in the same pr? |
Unfortunately, no. But you can close them, then squash your commits, then send a new PR. However, it's OK you can, just send two requests. |
Can check to see if my pull request for Chinese names went through? |
Sorry, no. |
Please check #37, if you still'd like to contribute. |
The repository is missing Chinese names and surnames. Follow the guide below to add them.
馃殌 How to Contribute:
馃搫 Format:
For names (
src/names/zh-cn.ts
):For surnames (
src/surnames/zh-cn.ts
):馃搶 Important Notes:
The text was updated successfully, but these errors were encountered: