Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese Names and Surnames #4

Closed
ozdemirburak opened this issue Oct 14, 2023 · 7 comments
Closed

Add Chinese Names and Surnames #4

ozdemirburak opened this issue Oct 14, 2023 · 7 comments
Labels

Comments

@ozdemirburak
Copy link
Owner

ozdemirburak commented Oct 14, 2023

The repository is missing Chinese names and surnames. Follow the guide below to add them.

馃殌 How to Contribute:

  1. Fork the repository.
  2. Add names and surnames for your country following the format provided below.
  3. Submit a Pull Request with your changes.
  4. Please include a reliable source for the names and surnames you're adding, preferably a public database or a reputable website.

馃搫 Format:

For names (src/names/zh-cn.ts):

const chineseNames = {
    0: [ // Male names - Add the URL of the names source here
        'Name1', 'Name2', 'Name3', ...
    ],
    1: [ // Female names - Add the URL of the names source here
        'Name1', 'Name2', 'Name3', ...
    ]
}

export default chineseNames;

For surnames (src/surnames/zh-cn.ts):

const saudiSurnames = [ // Add the URL of the surnames source here
    'Surname1', 'Surname2', 'Surname3', ...
];

export default chineseSurnames;

馃搶 Important Notes:

  • Ensure that the names and surnames you add are common and not specific to a small group.
  • 50 names for both males and females, and 50 surnames.
  • Organize the names with 10 entries per row.
  • Avoid adding names that might be offensive or inappropriate.
  • Ensure you're not violating any copyright or data privacy rules.
@ericmchen15
Copy link

Hello @ozdemirburak , could i please be assigned to this task? Thank you so much.

@ozdemirburak
Copy link
Owner Author

Sure, actually, there's no need to ask. As long as anyone follows the guidelines, I'm OK with merging any pull request.

@ericmchen15
Copy link

@ozdemirburak I made two pull requests because I wasn't sure exactly how to merge them, is there a way I can merge the two pull request together so they're in the same pr?

@ozdemirburak
Copy link
Owner Author

ozdemirburak commented Oct 16, 2023

Unfortunately, no. But you can close them, then squash your commits, then send a new PR. However, it's OK you can, just send two requests.

@ericmchen15
Copy link

Can check to see if my pull request for Chinese names went through?

@ozdemirburak
Copy link
Owner Author

Sorry, no.

@ozdemirburak
Copy link
Owner Author

ozdemirburak commented Oct 17, 2023

Please check #37, if you still'd like to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants