Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose details of PoijiRowSpecificException #308

Closed
virtual-machinist opened this issue Feb 29, 2024 · 6 comments
Closed

Expose details of PoijiRowSpecificException #308

virtual-machinist opened this issue Feb 29, 2024 · 6 comments

Comments

@virtual-machinist
Copy link
Contributor

Hi!

First of all, thank you for a wonderful library, the most feature-rich for parsing Excel spreadsheets I could find out there.

I have however a small feature request. When parsing the spreadsheet I must report all errors due to required missing data to an API. PoijiRowSpecificException does collect everything I want, but as a concatenated string. Parsing it back from the error message feels weird.

Can we expose the constructor parameters of PoijiRowSpecificException as properties in addition to the message?

Copy link

Thank you for contributing to Poiji! Feel free to create a PR If you want to contribute directly :)

@virtual-machinist
Copy link
Contributor Author

As a matter of fact, I could also use additional details in com.poiji.exception.HeaderMissingException, i.e.
missingExcelCellHeaders and missingExcelCellNameHeaders used to generate the message in AnnotationUtil:80.

@ozlerhakan, what do you think, is this something I can also add to the PR?

@ozlerhakan
Copy link
Owner

Hey @virtual-machinist ,

Thank you for contributing Poiji! I highly appreciate!

Please go ahead!

@virtual-machinist
Copy link
Contributor Author

@ozlerhakan, thanks, my pleasure.

I've updated the PR, both properties of HeaderMissingException are now exposed as well.

@ozlerhakan
Copy link
Owner

Hi @virtual-machinist , after the release deployment, you can use your enhancement with 4.4.0 :), thank you!

@virtual-machinist
Copy link
Contributor Author

Woah, that was fast. :) Thanks lots, @ozlerhakan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants