Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv has removed support for opengl_cb API and now vidcutter cannot compile #345

Closed
PhobosK opened this issue Jan 23, 2022 · 8 comments
Closed

Comments

@PhobosK
Copy link

PhobosK commented Jan 23, 2022

Hi MPV has already removed the support for the opengl_cb (mpv-player/mpv@6320598) and now vidcutter doesn't compile:

gcc -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -DOPENSSL_LOAD_CONF -fwrapv -fno-semantic-interposition -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -fPIC -I/usr/include/python3.8 -c vidcutter/libs/pympv/mpv.c -o build/temp.linux-x86_64-3.8/vidcutter/libs/pympv/mpv.o -g0
vidcutter/libs/pympv/mpv.c:630:10: fatal error: mpv/opengl_cb.h: No such file or directory
  630 | #include "mpv/opengl_cb.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

Tumbleweed already moved to the new libmpv2

Thanks

@easyteacher
Copy link

The package is going to be removed from Tumbleweed if it continues failing compiling.

@ozmartian
Copy link
Owner

ozmartian commented Feb 21, 2022

VidCutter was updated and switched from opengl_cb to MPV's new render API about 2 years ago. Perhaps there is some unneeded dependency in place somewhere.

@ozmartian
Copy link
Owner

Its an issue with pympv, a dependency. Should have this resolved sometime soon.

@ozmartian
Copy link
Owner

ozmartian commented Feb 22, 2022

I've just pushed a new commit with 3 changes to files in the pympv libs folder. These are simple patches, commenting out deprecated stuff from libmpv that aren't needed for this project anyway. Have tested it against latest mpv-git code so should be all good.

Have let OpenSUSE Leap package admin know. Not too sure where to go for Tumbleweed though?

@easyteacher
Copy link

easyteacher commented Feb 22, 2022

I have submitted a request for it. Thank you very much!

https://build.opensuse.org/request/show/956575

@ozmartian
Copy link
Owner

Champion. Thx!

@easyteacher
Copy link

Tested, no problem cutting videos.

@ozmartian
Copy link
Owner

Awesome. Thanks so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants