Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

larger key breaking sasl library #4

Closed
ozten opened this issue Nov 2, 2011 · 3 comments
Closed

larger key breaking sasl library #4

ozten opened this issue Nov 2, 2011 · 3 comments

Comments

@ozten
Copy link
Owner

ozten commented Nov 2, 2011

We currently send the assertion in the CB_AUTHNAME field. The latest assertions in production are larger than the max allowed for this field and are causing SASL_BUFOVER to be returned when we try to canonicalize the authname.

result = params->canon_user(params->utils->conn, browser_assertion, 0,
SASL_CU_AUTHZID, oparams);

This causes the server plugin to quit early and auth to fail.

Areas to explore:

  • User different fields
  • Figure out max lengths
  • Make a multi-step protocol based on max output length
  • ???
@ozten
Copy link
Owner Author

ozten commented Nov 3, 2011

I think I was using canon_user wrong on in the client plugin. It was 'working' by accident.

I was calling canon_user with the assertion and audience. I don't need to do this. canon_user should be called on the client side with the user's email address for both user and authname.

I'm currently investigating a two step protocol (instead of 1 step).
Client sends 'assertion NUL audience NUL'
Server sends back 'email NUL'

With this piece of information, the client can call canon_user.

@ozten
Copy link
Owner Author

ozten commented Nov 3, 2011

I've taken a stab at fixing this.

Also, sasl-browserid had fallen out of sync with browserid.org. Resp no longer contains valid_until, it has it as expires. Also fixed.

@ozten ozten closed this as completed Nov 3, 2011
@ozten
Copy link
Owner Author

ozten commented Nov 3, 2011

For reference
b0c2638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant