Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettimezones misnamed function #41

Closed
jfinstrom opened this issue Apr 24, 2019 · 3 comments
Closed

gettimezones misnamed function #41

jfinstrom opened this issue Apr 24, 2019 · 3 comments

Comments

@jfinstrom
Copy link
Contributor

The function that is called is gettimezone but the function name is gettimezones
jfinstrom added a commit to jfinstrom/icalparser that referenced this issue Apr 24, 2019
@jfinstrom
OzzyCzech#41 Misnamed method getTimezone
5b8b31e 
OzzyCzech#41 Add an alias method that points getTimezone to getTimezones.
Using an alias fixes this without breaking someone or somewhere that may point at the other method.
@jfinstrom jfinstrom mentioned this issue Apr 24, 2019
Merged
@Rotzbua
Copy link
Contributor

Rotzbua commented Apr 24, 2019

getTimezone and return value array is misleading

@jfinstrom
Copy link
Contributor Author

getTimezone and return value array is misleading

I am not sure what you mean. The forward function always returns an array per the docblock

@Rotzbua
Copy link
Contributor

Rotzbua commented Jun 10, 2019

I am not sure what you mean. The forward function always returns an array per the docblock

grammar

getTimezone = exactly 1 => single element => int, string
getTimezones = more than 1 => multiple element => array

OzzyCzech pushed a commit that referenced this issue Nov 6, 2019
Merge pull request #42 from jfinstrom/master
5ebd92e 
#41 Misnamed method getTimezone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OzzyCzech @jfinstrom @Rotzbua