Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue: pip install wilds changes pytorch version #132

Closed
mitchellnw opened this issue Sep 9, 2022 · 3 comments
Closed

Minor issue: pip install wilds changes pytorch version #132

mitchellnw opened this issue Sep 9, 2022 · 3 comments

Comments

@mitchellnw
Copy link

A really minor issue, but the pip install wilds changed my pytorch version which then caused some prior evals on non-wilds datasets to change slightly. Is it possible for this to not occur? No worries if not.

@mitchellnw
Copy link
Author

(For a bit of additional info, I was using 1.7.0 which is listed as ok on the readme, but the install changed it to 1.12)

@kohpangwei
Copy link
Collaborator

Hmm, thanks for pointing this out! I'm not sure -- setup.py just lists torch>=1.7.0. (https://github.com/p-lambda/wilds/blob/main/setup.py#L31)

Do you know if there are other dependencies that might be forcing the torch update, like with torchvision or with pyg?

@mitchellnw
Copy link
Author

Oh great point -- I think my torchvision may have been 0.8.1 and instead of just upgrading that it was upgrading everything. Ok, I'll close this issue - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants