Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile borders are visible #5

Closed
Nohus opened this issue Nov 21, 2021 · 5 comments
Closed

Tile borders are visible #5

Nohus opened this issue Nov 21, 2021 · 5 comments

Comments

@Nohus
Copy link
Collaborator

Nohus commented Nov 21, 2021

Here is a map displaying fully blue tiles:

image

The expected outcome would be just a blue image, but instead the tiles are clearly visible.

@p-lr
Copy link
Owner

p-lr commented Nov 21, 2021

This one is nasty, and a bit embarrassing.
Though I managed to fix it, I need to be sure of the changes.

@p-lr p-lr closed this as completed in e3f3781 Nov 21, 2021
@Nohus
Copy link
Collaborator Author

Nohus commented Nov 21, 2021

This issue is still present. The fix seemed to have helped, the lines are now less common and are even completely gone at specific zoom levels, but are otherwise still very much visible.

@p-lr p-lr reopened this Nov 21, 2021
@p-lr
Copy link
Owner

p-lr commented Nov 21, 2021

Turns out, tile placement was originally right.
It seems like an undesirable effect of the api used to place tiles on the canvas. To test that, I have drawn on the canvas squares of the same size and at the same positions of tiles. The result is a smooth concatenation of the squares (no borders).

Which makes me think that there might be an issue upstream, with the DrawScope.drawImage API. A good thing is (if I'm right) that should be easy to reproduce outside of this library.
Meanwhile, I'm reverting my changes.

@Nohus
Copy link
Collaborator Author

Nohus commented Nov 22, 2021

What is the outlook on fixing this then? 🤔

@Nohus
Copy link
Collaborator Author

Nohus commented Nov 23, 2021

Fixed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants