Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete frames being send during MultiPath-supported connection #16

Closed
The3ternum opened this issue Oct 29, 2020 · 3 comments
Closed

Comments

@The3ternum
Copy link

While handling a connection that supports the multipath extension, the server sends MP-frames, such as ADD_ADDRESS and MP_NEW_CONNECTION_ID, which lack certain fields. E.g.: there is no retire_prior_to-field being wirtten to the frame MP_NEW_CONNECTION_ID.

I will update this issue with other frames that are incomplete when I inspect the source-code of the multipath plugin.

@qdeconinck
Copy link
Member

The format of ADD_ADDRESS and MP_NEW_CONNECTION_ID should be fixed now.

@The3ternum
Copy link
Author

The handling of received ACK-frames also seems to have an issue when using the multipath plugin. The error it gives is the following, logged everytime a regular ack was received: ERROR: trying to get input 5, but there are only 5 inputs available

@mpiraux
Copy link
Member

mpiraux commented Jan 7, 2021

ERROR: trying to get input 5, but there are only 5 inputs available

This is due to also plugging in the MP ACK logic to the ACK logic, but the code does handle that properly. It's a bit ambiguous for sure though.

@mpiraux mpiraux closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants