Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Tsx colors are the other way around #123

Closed
FernandoChu opened this issue Jul 14, 2022 · 5 comments
Closed

Tsx colors are the other way around #123

FernandoChu opened this issue Jul 14, 2022 · 5 comments

Comments

@FernandoChu
Copy link

Describe the bug
Tsx colors are the other way around, tags are getting colored, while typescript type annotations are not.

Steps to reproduce
Enable rainbow without extended_mode.

  rainbow = {
    enable = true,
    extended_mode = false
  }

Example code:

const Secret = () => {
  const test: Array<Array<number>> = [[]];

  return (
    <main>
      <div>
        <p>{test}</p>
      </div>
    </main>
  );
};

export default Secret;

Expected behavior
Same behavior as jsx files: jsx tags don't get colored, but with the addition of types annotations getting colored.

Screenshots
Tsx not working correctly
image

Jsx working fine
image

@p00f
Copy link
Owner

p00f commented Jul 14, 2022

Type annotations not being highlighted is intended, not sure about the nested arrays in tsx though. Can you try out the issue_123 branch to see if the tsx tags are fixed

@FernandoChu
Copy link
Author

Arrays are working correctly now, tsx tags are not though

@p00f
Copy link
Owner

p00f commented Jul 14, 2022

This one should be fixed but extended mode in jsx doesn't work for some reason

@p00f p00f closed this as completed in e486fad Jul 14, 2022
@Alex23rodriguez
Copy link

is there a branch where this issue is fixed? I just updated the package and tsx files are now messed up for me

image

@Gelio
Copy link
Contributor

Gelio commented Aug 7, 2022

@Alex23rodriguez This should be fixed by #125

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants