Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] set ssid with blank spaces #62

Closed
rafonsecad opened this issue Jul 1, 2020 · 1 comment
Closed

[Request] set ssid with blank spaces #62

rafonsecad opened this issue Jul 1, 2020 · 1 comment
Labels
feature requests feature requests solved bugs that have been solved status: in progress the solution is in progress type: enhancement New feature or request

Comments

@rafonsecad
Copy link
Contributor

From what I've seen so far, setting any ssid with blank spaces won't set the whole ssid but only the first word.

To Reproduce
Steps to reproduce the behavior:

  1. On the terminal type $ wifipumpkin3
  2. type any ssid with spaces, i.e., $ set ssid "network 1"
  3. wifipumpkin will only recognize the first word as the name of the network, in this case "network

Expected behavior
It would be very convenient to include the whole name of the network in the ssid field. The only workaround I know is to edit directly the config.ini file before wifipumpkin3 is executed.

My guess to include this feature is a change in wifipumpkin/core/common/terminal.py file, specifically, the function do_set

    def do_set(self, args):
        """ set options for module """
        try:
            command, value = args.split()[0], args.split()[1]

As we can see above, command and value are both set after a split, so we can change the way value has its value by first looking if there is a pair of double quotes, otherwise take the value of args.split()[1]. I tried to implement such features but I got confused creating the unit test.

Thanks for reading this

  • Virtual Machine (yes or no and which): Docker version
  • Operating System: Ubuntu 20.04
  • version: 8e12ef3
@mh4x0f mh4x0f added feature requests feature requests type: enhancement New feature or request status: in progress the solution is in progress labels Jul 2, 2020
mh4x0f added a commit that referenced this issue Jul 5, 2020
@mh4x0f
Copy link
Member

mh4x0f commented Jul 5, 2020

I pushed a solution, but I should be add a validator for ssid, like can see on hostapd documentation. btw, tthank's for nices reports.

@mh4x0f mh4x0f added the solved bugs that have been solved label Jul 5, 2020
@mh4x0f mh4x0f closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature requests feature requests solved bugs that have been solved status: in progress the solution is in progress type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants